The effects of ferric ion, pH, and bromide on the formation and distribution of disinfection byproducts (DBPs) during chlorination were studied. Two raw water samples from Huangpu River and Yangtze River, two typical drinking water sources of Shanghai, were used for the investigation. Compared with the samples from Huangpu River, the raw water samples from Yangtze River had lower content of total organic carbon (TOC) and ferric ions, but higher bromide concentrations. Under controlled chlorination conditions, four trihalomethanes (THMs), nine haloacetic acids (HAAs), total organic halogen (TOX) and its halogen species fractions, including total organic chlorine (TOC1) and total organic bromide (TOBr), were determined. The results showed that co-existent ferric and bromide ions significantly promoted the formation of total THMs and HAAs for both raw water samples. Higher concentration of bromide ions significantly changed the speciation of the formed THMs and HAAs. There was an obvious shift to brominated species, which might result in a more adverse influence on the safety of drinking water. The results also indicated that high levels of bromide ions in raw water samples produced higher percentages of unknown TOBr.